Added toaster for removed NFTs #17297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NidhiKJha
added
area-NFTs
team-extension-ux
darkwing
requested changes
Jan 19, 2023
ui/pages/home/home.component.js
Outdated
|
|
||
| {removeCollectibleMessage === 'success' ? ( | ||
| <ActionableMessage | ||
| type="success" |
There was a problem hiding this comment.
We want this to be type="danger" so that it's red.
ui/pages/settings/security-tab/__snapshots__/security-tab.test.js.snap
Outdated
Show resolved
Hide resolved
Builds ready [00149f5]
Page Load Metrics (1401 ± 135 ms)
highlights:storybook
|
Codecov Report
@@ Coverage Diff @@
## develop #17297 +/- ##
===========================================
- Coverage 59.80% 59.79% -0.02%
===========================================
Files 937 937
Lines 36141 36154 +13
Branches 9284 9287 +3
===========================================
+ Hits 21614 21615 +1
- Misses 14527 14539 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
DDDDDanica
reviewed
Jan 20, 2023
DDDDDanica
approved these changes
Jan 20, 2023
darkwing
approved these changes
Jan 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the toaster function with an "NFT removed" message as we have for "Successfully Added Collectibles".
Fixes #17140
After
Screen.Recording.2023-01-19.at.11.43.09.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist